ci(docs-infra): change test order and track payload size for local and Ivy #31047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added
action: merge
|
You can preview ab5a36f at https://pr31047-ab5a36f.ngbuilds.io/. |
gkalpak
force-pushed
the
ci-aio-improvements
branch
from
ab5a36f
to
ded9c99
Compare
|
You can preview ded9c99 at https://pr31047-ded9c99.ngbuilds.io/. |
gkalpak
force-pushed
the
ci-aio-improvements
branch
from
ded9c99
to
03af4dc
Compare
|
You can preview 03af4dc at https://pr31047-03af4dc.ngbuilds.io/. |
petebacondarwin
approved these changes
Jun 14, 2019
|
Except for the CI failures! |
|
You can preview 93f4e4e at https://pr31047-93f4e4e.ngbuilds.io/. |
filipesilva
approved these changes
Jun 14, 2019
Previously, we run the PWA score tests before unit/e2e tests, because the latter would destroy the `dist/` directory required by the former. Since cli@6, unit/e2e tests no longer detroy the `dist/` directory, so it is now safe to run the unit/e2e tests first. This is preferrable, since they are conceptually lower-level and any error messages (in case of breakage) are more specific/actionable. Related discussion about cli behavior: - angular/angular-cli#4366 - angular/angular-cli#14701
…d `test_aio_local_ivy`
…cal` and `test_aio_local_ivy`
gkalpak
force-pushed
the
ci-aio-improvements
branch
from
93f4e4e
to
501769d
Compare
|
You can preview 501769d at https://pr31047-501769d.ngbuilds.io/. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jun 14, 2019
Previously, we run the PWA score tests before unit/e2e tests, because the latter would destroy the `dist/` directory required by the former. Since cli@6, unit/e2e tests no longer detroy the `dist/` directory, so it is now safe to run the unit/e2e tests first. This is preferrable, since they are conceptually lower-level and any error messages (in case of breakage) are more specific/actionable. Related discussion about cli behavior: - angular/angular-cli#4366 - angular/angular-cli#14701 PR Close #31047
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small CI-related improvements:
test_aio_localandtest_aio_local_ivy(See individual commits for more details.)